*: test expired certs in client #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
suggested changes
Apr 26, 2017
clientv3/integration/dial_test.go
Outdated
| ClientCertAuth: true, | ||
| } | ||
|
|
||
| testTLSInfoBad = transport.TLSInfo{ |
clientv3/integration/dial_test.go
Outdated
| } | ||
|
|
||
| testTLSInfoBad = transport.TLSInfo{ | ||
| KeyFile: "../../integration/fixtures-bad/server-key.pem", |
clientv3/integration/dial_test.go
Outdated
| } | ||
|
|
||
| // expect remote errors 'tls: bad certificate' | ||
| _, err = integration.NewClientV3TLS(clus.Members[0], &testTLSInfoBad) |
There was a problem hiding this comment.
no need to extend the integration package API:
_, err = clientv3.New(clientv3.Config{
Endpoints: []string{clus.Members[0].GRPCAddr()},
TLS: &testTLSInfoExpired,
})
clientv3/integration/dial_test.go
Outdated
| clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1, PeerTLS: &testTLSInfo, ClientTLS: &testTLSInfo}) | ||
| defer clus.Terminate(t) | ||
|
|
||
| c1, err := integration.NewClientV3(clus.Members[0]) |
There was a problem hiding this comment.
can this be left out? Seems like other tests should cover the success case already
|
Maybe change commit title from using the keyword
|
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
changed the title
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
@heyitsanthony @fanminshi All addressed. PTAL. Thanks. |
heyitsanthony
approved these changes
Apr 26, 2017
|
lgtm |
fanminshi
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to have some testing cases for #7784 and #7807.